Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmtotuple(): use time_t for gmtoff #1276

Merged
merged 1 commit into from
Apr 24, 2017
Merged

tmtotuple(): use time_t for gmtoff #1276

merged 1 commit into from
Apr 24, 2017

Conversation

vstinner
Copy link
Member

timegm() return type is time_t, not int. Use time_t to prevent the
following compiler warning on Windows:

timemodule.c: warning C4244: '=': conversion from 'time_t' to 'int',
possible loss of data

@mention-bot
Copy link

@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba, @Yhg1s and @abalkin to be potential reviewers.

@vstinner
tmtotuple(): use time_t for gmtoff
3b3b386 
timegm() return type is time_t, not int. Use time_t to prevent the
following compiler warning on Windows:

timemodule.c: warning C4244: '=': conversion from 'time_t' to 'int',
              possible loss of data
@vstinner vstinner merged commit 0d659e5 into python:master Apr 24, 2017
@vstinner vstinner deleted the gmtoff branch April 24, 2017 23:22
@vstinner
Copy link
Member Author

On AppVeyor, timemodule.c compilation now doesn't produce any warning, and test_time passed.

abalkin
abalkin reviewed Apr 25, 2017
View reviewed changes
Copy link
Member

@abalkin abalkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member Author

@abalkin: FYI I already merged the change, but thanks for your review. I forgot to nosy you, I forgot that the compiler warning was related to time ;-)

vstinner added a commit that referenced this pull request May 17, 2017
@vstinner
tmtotuple(): use time_t for gmtoff (#1276) (#1635)
69f3a5a 
timegm() return type is time_t, not int. Use time_t to prevent the
following compiler warning on Windows:

timemodule.c: warning C4244: '=': conversion from 'time_t' to 'int',
              possible loss of data
(cherry picked from commit 0d659e5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abalkin abalkin abalkin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @mention-bot @abalkin @the-knights-who-say-ni