-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-127536: Add missing locks in listobject.c #127580
Conversation
We were missing locks around some list operations in the free threading build.
20ae0a8
to
fb7b2af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but do you think it would be worthwhile to audit the functions that we expect to be called with the per-object lock held and add _Py_CRITICAL_SECTION_ASSERT_OBJECT_LOCKED()
or the equivalent where they're missing?
Yes, I think additional |
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @colesbury, I could not cleanly backport this to
|
GH-127613 is a backport of this pull request to the 3.13 branch. |
|
|
We were missing locks around some list operations in the free threading build.
We were missing locks around some list operations in the free threading build.
listobject.c
#127536