-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-28851: DOC: Retrofit changes to collections.rst from 2.7 #1274
Conversation
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @rhettinger and @tiran to be potential reviewers. |
This changes things unrelated to field_names, some of which were already made in revision 15aded8 and recently undone: https://bugs.python.org/issue27205. Did you try running the doc tests? If we cannot agree on the best way to mark up example code, I suggest to leave it as it is. Otherwise, it would be good to negotiate with the doc test bug or the people involved: @JelleZijlstra, @marco-buttu. |
I ran './python -m test' and test_collections passed, but maybe that's not the test you mean? The bug ticket for 28851 didn't mention the other issue, so I thought it just needed to be retrofitted from that older revision into the newest docs. |
I think Martin was referring to doctests, which you can run by running |
Otherwise I'm not familiar with the linked changes, but it seems better to drop unrelated modifications from this PR. |
Please restore the PS2 prompts. The examples are cut-and-pastable, just press on the button at right top corner of an example box. |
OK. I copied and pasted the comments from the original PR by RH, so he had made the bullet about them not being able to be cut and pasted. But, thank you for clarifying for me. This is all a learning experience and I appreciate everyone's patience. And thank you for telling me about 'make doctest'. |
Clarify that a sequence of strings is the preferred value for 'field_names'. (cherry picked from commit 97bf722)
Notes from the original change in 2.7:
Minor doc clean-up.