Skip to content

gh-87506: Document that json.load*() can raise UnicodeDecodeError#127355

Merged
erlend-aasland merged 6 commits intopython:mainfrom
srinivasreddy:gh_87506
Jan 8, 2025
Merged

gh-87506: Document that json.load*() can raise UnicodeDecodeError#127355
erlend-aasland merged 6 commits intopython:mainfrom
srinivasreddy:gh_87506

Conversation

@srinivasreddy
Copy link
Contributor

@srinivasreddy srinivasreddy commented Nov 28, 2024

gh-87506: Improve the documentation for json.load() and json.loads()

@srinivasreddy
Copy link
Contributor Author

Since @serhiy-storchaka moved this into JSON issues, I am raising this PR.
If @rhettinger still feel that it is okay to forgo this documentation update since we cannot,(should not) comprehensively document every exception. And in that case we can successfully close the issue.

@skirpichev skirpichev changed the title gh-87505: Improve the documentation for json.load() and json.loads() gh-87506: Improve the documentation for json.load() and json.loads() Nov 28, 2024
@rhettinger rhettinger removed their request for review November 29, 2024 03:39
@erlend-aasland erlend-aasland self-requested a review January 4, 2025 17:42
@erlend-aasland erlend-aasland self-assigned this Jan 4, 2025
@erlend-aasland

This comment was marked as resolved.

@erlend-aasland
Copy link
Contributor

@srinivasreddy, please pull in main and resolve the conflicts.

@cjw296
Copy link
Contributor

cjw296 commented Jan 8, 2025

@erlend-aasland - please bear in mind that "pull in main" results in an awful lot of unrelated folks getting spammed by this PR. Better would be to rebase the branch on main.

@cjw296 cjw296 removed their request for review January 8, 2025 06:41
@methane
Copy link
Member

methane commented Jan 8, 2025

rebase on main also trigger this PR corruption.
Recommended way is git pull upstream main.

See these:

@erlend-aasland
Copy link
Contributor

@erlend-aasland - please bear in mind that "pull in main" results in an awful lot of unrelated folks getting spammed by this PR. Better would be to rebase the branch on main.

This is absolutely not correct.

srinivasreddy and others added 3 commits January 8, 2025 12:55
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miss-islington-app

This comment was marked as outdated.

@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

GH-128607 is a backport of this pull request to the 3.13 branch.

@bedevere-app
Copy link

bedevere-app bot commented Jan 8, 2025

GH-128608 is a backport of this pull request to the 3.12 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

json.load() can raise UnicodeDecodeError, but this is not documented

6 participants