Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-127196: Fix crash in _interpreters, when shared had invalid encodings #127220

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-127196: Fix crash in _interpreters, when shared had invalid encodings #127220

wants to merge 1 commit into from
+20 −2

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Nov 24, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn added the needs backport to 3.13 bugs and security fixes label Nov 24, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 24, 2024
Open
ZeroIntensity
ZeroIntensity approved these changes Nov 24, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this was the fix I was thinking of. LGTM.

vstinner
vstinner approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_run_in_interpreter() fix LGTM, and tests cover the modified code path.

@sobolevn
Copy link
Member Author

Thank you! I will wait for @ericsnowcurrently's review, because this is an important part of the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@vstinner vstinner vstinner approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.13 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @vstinner @ZeroIntensity