gh-127146: Emscripten: Skip segfaults in test suite

[hoodmane]

After this, Emscripten makes it all the way through the test suite when I run it locally.

• Issue: Emscripten: Get test suite passing #127146

[mdboom]

Sorry if this sounds overly pedantic, but isn't this "skipping tests that segfault" rather than "fixing tests that segfault"? It's a completely reasonably path to skip these tests and then come back later to fix them (if they matter), but I would suggest changing the PR title / commit message.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[hoodmane]

As a mathematician I have no right to call anyone pedantic under practically any circumstances.

[hoodmane]

Seems like I can remove a lot of these xfails if I set -sSTACK_SIZE=10mb instead of 5mb.

[hoodmane]

Nevermind that is not true.

[freakboy3742]

The set of changes all looks fine to me.

However, if this is going to be a common mode of failure for tests (which this PR seems to indicate it will be), I'd rather see it pulled into a utility decorator, analogous to requires_subprocess (e.g., requires_full_stack?) so that the skip message is consistent.

[hoodmane]

Okay @freakboy3742 I made a common method for the stack-overflow skips. I also updated the description according to @mdboom's complaint.

I have made the requested changes; please review again

[bedevere-app]

Thanks for making the requested changes!

@freakboy3742, @mdboom: please review the changes made to this pull request.

[freakboy3742]

One possible cleanup that I should have found on my first pass. There's also a bunch of CI failures that I'm fairly sure are due to one misapplied test decorator.

[bedevere-app]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[hoodmane]

Okay, I have made the requested changes; please review again

[bedevere-app]

Thanks for making the requested changes!

@mdboom, @freakboy3742: please review the changes made to this pull request.

[freakboy3742]

LGTM - thanks for those fixes!

[freakboy3742]

@mdboom Do the changes @hoodmane has made address your concerns? I'm happy to merge in the current state.

[Eclips4]

test_ast changes looks good to me.

[hoodmane]

If @mdboom doesn't come back to approve this, maybe you can merge it @freakboy3742? I think I addressed his comment...