gh-119786: add code object doc, inline locations.md into it #126832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
iritkatriel
commented
Nov 14, 2024
•
iritkatriel
commented
- Issue: create an internals documentation folder in the cpython repo #119786
|
I'm super busy at work right now -- happy to take a look, but probably won't have a chance to until at least the weekend |
Eclips4
reviewed
Nov 14, 2024
iritkatriel
commented
Nov 14, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
markshannon
requested changes
Nov 22, 2024
InternalDocs/code_objects.md
Outdated
|
|
||
| > [!NOTE] | ||
| > `co_linetable` is not to be confused with `co_lnotab`. | ||
| > For backwards compatibility, `co_lnotab` stores the format |
There was a problem hiding this comment.
Note that co_lnotab is lazily created from co_linetable when requested
|
When you're done making the requested changes, leave the comment: |
|
Thanks. I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @markshannon, @AlexWaygood: please review the changes made to this pull request. |
markshannon
approved these changes
Nov 22, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.