Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed capital letters missing and missing . #12584

Merged
merged 3 commits into from
Mar 28, 2019
Merged

Fixed capital letters missing and missing . #12584

merged 3 commits into from
Mar 28, 2019

Conversation

Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Mar 27, 2019

No bpo for minor doc fix

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 27, 2019
@Seluj78 Seluj78 mentioned this pull request Mar 27, 2019
Merged
eamanu
eamanu approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Seluj78
Copy link
Contributor Author

Seluj78 commented Mar 27, 2019

cc @birkenfeld

@csabella
Copy link
Contributor

I can understand why this is lower case; it is using the New in version 3.1: part as the beginning of the sentence. However, it may be better to make this more of a complete sentence in itself, such as Added under the name.

There is another lower case example under the Deprecated Alias section:
Deprecated since version 3.1: the fail* aliases listed in the second column.

That one would probably should have the the capitalized.

@eamanu
Copy link
Contributor

eamanu commented Mar 27, 2019

@csabella mmm yes ... sound good that you say, but on the line 1005 on the versionchanged Renamed to :meth:`assertRaisesRegex`. start with capital.

@Seluj78
Copy link
Contributor Author

Seluj78 commented Mar 27, 2019

Done @csabella

brettcannon
brettcannon requested changes Mar 27, 2019
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the sentences are going to be edited then they should be made into complete sentences.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@brettcannon @Seluj78
Apply suggestions from code review
81a9113 
Co-Authored-By: Seluj78 <jlasne@student.42.fr>
@Seluj78
Copy link
Contributor Author

Seluj78 commented Mar 28, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@brettcannon: please review the changes made to this pull request.

@miss-islington miss-islington merged commit 3d78c4a into python:master Mar 28, 2019
@miss-islington
Copy link
Contributor

Thanks @Seluj78 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12612 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 28, 2019
@Seluj78 @miss-islington
Fixed capital letters missing and missing . (pythonGH-12584)
dfa56d5 
No `bpo` for minor doc fix
(cherry picked from commit 3d78c4a)

Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
miss-islington added a commit that referenced this pull request Mar 29, 2019
@miss-islington @Seluj78
Fixed capital letters missing and missing . (GH-12584)
40ee9a3 
No `bpo` for minor doc fix
(cherry picked from commit 3d78c4a)

Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Seluj78 @csabella @eamanu @bedevere-bot @miss-islington @brettcannon @the-knights-who-say-ni