gh-121459: Fix a couple of uses of PyStackRef_FromPyObjectSteal
#125711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed in pythongh-124894
This was missed in pythongh-124894
colesbury
approved these changes
Oct 18, 2024
rruuaanng
reviewed
Oct 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Hi @fiona02! AI tools are wonderful, but they're not particularly helpful when it comes to PR reviews--typically, they're just sampling and regurgitating what we've already written before. Please refer to the devguide on how to contribute :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-124894 disallowed passing NULL pointers to
_PyStackRef_FromPyObjectSteal. Refactor the use of_PyStackRef_FromPyObjectStealinCALL_TUPLE_1and_CALL_STR_1to avoid passing NULL pointers.I ran into this while getting
CALLspecializations working in the free-threaded build. We aren't running into this currently because_PyStackRef_FromPyObjectStealonly asserts in the free-threaded build and these specializations are disabled in free-threaded builds.