-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-125174: Make immortal objects more robust, following design from PEP 683 #125251
GH-125174: Make immortal objects more robust, following design from PEP 683 #125251
Conversation
markshannon
commented
Oct 10, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: "Immortal" objects aren't immortal and that breaks things. #125174
This is not a complete fix for #125174, just enough to unblock other work |
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 94f8fd0 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
The two "failing" refleak buildbots seem to be hanging in |
Performance impact: Overall a small slowdown, with a large 7-10% slowdown on nbody. I'll re-run the linux benchmarks with the fix as a sanity check. |
Windows shows an over 2% improvement. With the regression fixed, this I would expect this to be more than 3%. This reason for this is that the MSVC does not convert |
x86-64 linux performance numbers are a bit noisy, but show no significant change. |
python/cpython#125251 renamed _PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT
* MNT: account for CPython 314 changes python/cpython#125251 renamed _PY_IMMORTAL_REFCNT -> _PY_IMMORTAL_INITIAL_REFCNT * Define new macro to reduce duplication --------- Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>