gh-124969: Fix locale.nl_langinfo(locale.ALT_DIGITS) #124974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it returns a tuple of up to 100 strings (an empty tuple on most locales). Previously it returned the first item of that tuple or an empty string.
serhiy-storchaka
force-pushed
the
locale-nl_langinfo-alt_digits
branch
from
999217d
to
e062187
Compare
methane
reviewed
Oct 8, 2024
serhiy-storchaka
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 157c23e 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
methane
approved these changes
Oct 9, 2024
|
Thank you for your review @methane. I wonder what happened with ALT_DIGITS on macOS whether it only for Japanese (which have lesser need of this info for |
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
This commit broke the iOS buildbot: https://buildbot.python.org/#/builders/1380/builds/1535/steps/10/logs/stdio |
efimov-mikhail
pushed a commit
to efimov-mikhail/cpython
that referenced
this pull request
Oct 9, 2024
…124974) Now it returns a tuple of up to 100 strings (an empty tuple on most locales). Previously it returned the first item of that tuple or an empty string.
|
Thanks. Should be fixed by #125177. |
serhiy-storchaka
removed
needs backport to 3.12
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 10, 2024
…thonGH-124974) Now it returns a tuple of up to 100 strings (an empty tuple on most locales). Previously it returned the first item of that tuple or an empty string. (cherry picked from commit 21c04e1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-125232 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 10, 2024
…thonGH-124974) Now it returns a tuple of up to 100 strings (an empty tuple on most locales). Previously it returned the first item of that tuple or an empty string. (cherry picked from commit 21c04e1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
freakboy3742
pushed a commit
that referenced
this pull request
Oct 10, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 10, 2024
…thonGH-124974) (pythonGH-125232) (cherry picked from commit 26a9318) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Returns a tuple of up to 100 strings for ALT_DIGITS lookup (an empty tuple on most locales). Previously it returned the first item of that tuple or an empty string. (cherry picked from commit 21c04e1)
serhiy-storchaka
added a commit
that referenced
this pull request
Oct 11, 2024
…H-124974) (GH-125232) (GH-125284) (cherry picked from commit 26a9318) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Returns a tuple of up to 100 strings for ALT_DIGITS lookup (an empty tuple on most locales). Previously it returned the first item of that tuple or an empty string. (cherry picked from commit 21c04e1) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Oct 21, 2024
… a string again This is a follow up of pythonGH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2024
… a string again (pythonGH-125774) This is a follow up of pythonGH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms. (cherry picked from commit dcc4fb2) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2024
… a string again (pythonGH-125774) This is a follow up of pythonGH-124974. Only Glibc needed a fix. Now the returned value is a string consisting of semicolon-separated symbols on all Posix platforms. (cherry picked from commit dcc4fb2c9068f60353f0c0978948b7681f7745e6) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--124974.org.readthedocs.build/