Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-107954: Fix configuration type for the perf profiler #124636

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 26, 2024

@diegorusso
Copy link
Contributor

@pablogsal thanks! I confirm that this PR fixes #124613

@diegorusso
Copy link
Contributor

Tests are failing, I think they need to be updated as well.

======================================================================
FAIL: test_config_get (test.test_capi.test_config.CAPITests.test_config_get) (name='perf_profiling', option_type=<class 'bool'>, sys_attr=None)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/admin/actions-runner/_work/cpython/cpython/Lib/test/test_capi/test_config.py", line 130, in test_config_get
    self.assertIsInstance(value, option_type)
    ~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 is not an instance of <class 'bool'>

@vstinner
Copy link
Member

@pablogsal: I pushed a change in your PR to update tests.

@vstinner
Copy link
Member

I didn't know that perf_profiling can have two values, 1 or 2. It's not documented.

@pablogsal: I also pushed a change to complete the doc and add more tests. Would you mind to review my change?

@diegorusso
Copy link
Contributor

Thanks folks, I've tested the PR in our internal CI and all the tests are passing. LGTM.

@ambv ambv merged commit 02b49c5 into python:main Sep 27, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants