-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-107954: Fix configuration type for the perf profiler #124636
Conversation
pablogsal
commented
Sep 26, 2024
•
edited by bedevere-app
bot
Loading
edited by bedevere-app
bot
- Issue: [C API] PEP 741: Add PyInitConfig C API to customize the Python initialization #107954
@pablogsal thanks! I confirm that this PR fixes #124613 |
Tests are failing, I think they need to be updated as well.
|
@pablogsal: I pushed a change in your PR to update tests. |
I didn't know that perf_profiling can have two values, 1 or 2. It's not documented. @pablogsal: I also pushed a change to complete the doc and add more tests. Would you mind to review my change? |
Thanks folks, I've tested the PR in our internal CI and all the tests are passing. LGTM. |