Skip to content

Fix registry key for windows sdk detection #12445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Mar 19, 2019

Was broken by #4298

I don't think there's a need for an issue, but I can make one if you want.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@zooba
Copy link
Member

zooba commented Mar 21, 2019

Thanks for the fix!

@zooba zooba merged commit aedc273 into python:master Mar 21, 2019
@miss-islington
Copy link
Contributor

Thanks @isuruf for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @isuruf for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @isuruf for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @isuruf and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker aedc273fd90e31c7a20904568de3115f8957395b 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2019
(cherry picked from commit aedc273)

Co-authored-by: Isuru Fernando <isuruf@gmail.com>
@bedevere-bot
Copy link

GH-12487 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Mar 21, 2019
(cherry picked from commit aedc273)

Co-authored-by: Isuru Fernando <isuruf@gmail.com>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Mar 25, 2019
(cherry picked from commit aedc273)

Co-authored-by: Isuru Fernando <isuruf@gmail.com>
jjhelmus added a commit to regro-cf-autotick-bot/python-feedstock that referenced this pull request Mar 27, 2019
Patch is un-needed as change was merged upstream, see python/cpython#12445
@isuruf isuruf deleted the patch-2 branch April 5, 2019 14:15
mingwandroid pushed a commit to AnacondaRecipes/python-feedstock that referenced this pull request Dec 30, 2019
Patch is un-needed as change was merged upstream, see python/cpython#12445
deletedcu pushed a commit to deletedcu/python-feedstock that referenced this pull request Jul 20, 2021
Patch is un-needed as change was merged upstream, see python/cpython#12445
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants