-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
Fix registry key for windows sdk detection #12445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Was broken by python#4298
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
Thanks for the fix! |
Sorry, @isuruf and @zooba, I could not cleanly backport this to |
(cherry picked from commit aedc273) Co-authored-by: Isuru Fernando <isuruf@gmail.com>
GH-12487 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit aedc273) Co-authored-by: Isuru Fernando <isuruf@gmail.com>
(cherry picked from commit aedc273) Co-authored-by: Isuru Fernando <isuruf@gmail.com>
Patch is un-needed as change was merged upstream, see python/cpython#12445
Patch is un-needed as change was merged upstream, see python/cpython#12445
Patch is un-needed as change was merged upstream, see python/cpython#12445
Was broken by #4298
I don't think there's a need for an issue, but I can make one if you want.