gh-99108: Disable HACL SIMD code on older versions of Android#124304
Merged
freakboy3742 merged 1 commit intopython:mainfrom Sep 23, 2024
Merged
gh-99108: Disable HACL SIMD code on older versions of Android#124304freakboy3742 merged 1 commit intopython:mainfrom
freakboy3742 merged 1 commit intopython:mainfrom
Conversation
Member
Author
|
!buildbot android |
6 tasks
Member
Author
|
The x86-64 builder wasn't ready earlier, but it's passed now. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build is currently failing on Android x86-64:
This is because
aligned_allocwas only added to Android in API level 28, while we're building against level 21. So this PR disables the SIMD code completely when building against older Android versions.