Skip to content

gh-123942: add missing test for docstring-handling code in ast_opt.c #123943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2024
Merged

gh-123942: add missing test for docstring-handling code in ast_opt.c #123943

merged 4 commits into from
Sep 11, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 11, 2024 •
edited by bedevere-app bot
Loading

@iritkatriel iritkatriel added tests Tests in the Lib/test dir interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 11, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 11, 2024
Closed
@JelleZijlstra
Copy link
Member

I also looked at this code before and it's a little tricky, so good call on adding these tests.

@iritkatriel iritkatriel merged commit 6e23c89 into python:main Sep 11, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2024
@iritkatriel @miss-islington
pythongh-123942: add missing test for docstring-handling code in ast_…
19ffdd9 
…opt.c (pythonGH-123943)

(cherry picked from commit 6e23c89)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry, @iritkatriel, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6e23c89fcdd02b08fa6e9fa70d6e90763ddfc327 3.12

@bedevere-app
Copy link

bedevere-app bot commented Sep 11, 2024

GH-123955 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 11, 2024
@iritkatriel iritkatriel removed the needs backport to 3.12 only security fixes label Sep 11, 2024
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @iritkatriel
[3.13] gh-123942: add missing test for docstring-handling code in ast…
793cb77 
…_opt.c (GH-123943) (#123955)

gh-123942: add missing test for docstring-handling code in ast_opt.c (GH-123943)
(cherry picked from commit 6e23c89)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@iritkatriel iritkatriel

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing test for docstring-handling code in ast_opt.c
2 participants
@iritkatriel @JelleZijlstra