Skip to content

[3.6] bpo-34745: Fix asyncio sslproto memory issues (GH-12386) #12393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.6] bpo-34745: Fix asyncio sslproto memory issues (GH-12386) #12393

wants to merge 1 commit into from

Conversation

fantix
Copy link
Contributor

@fantix fantix commented Mar 18, 2019 •
edited
Loading

  • Fix handshake timeout leak in asyncio/sslproto, refs Fixes #220 sslproto memory issue MagicStack/uvloop#222
  • Break circular ref _SSLPipe <-> SSLProtocol
  • bpo-34745: Fix asyncio ssl memory leak
  • Break circular ref SSLProtocol <-> UserProtocol
  • Add NEWS entry
  • Dropped unit test whose base test is missing in 3.6 <-- Please kindly suggest

(cherry picked from commit f683f46)

https://bugs.python.org/issue34745

https://bugs.python.org/issue34745

@fantix
bpo-34745: Fix asyncio sslproto memory issues (pythonGH-12386)
7b6768b 
* Fix handshake timeout leak in asyncio/sslproto, refs MagicStack/uvloop#222

* Break circular ref _SSLPipe <-> SSLProtocol

* bpo-34745: Fix asyncio ssl memory leak

* Break circular ref SSLProtocol <-> UserProtocol

* Add NEWS entry
@bedevere-bot bedevere-bot mentioned this pull request Mar 18, 2019
Merged
@1st1
Copy link
Member

1st1 commented Mar 18, 2019

Dropped unit test whose base test is missing in 3.6 <-- Please kindly suggest

Can't we backport it?

@fantix
Copy link
Contributor Author

fantix commented Mar 18, 2019

For some reason, a lot of sslproto test code is missing on 3.6. Let me try to backport all of them later today.

@1st1
Copy link
Member

1st1 commented Mar 18, 2019

Oh, it's fine then, I'll merge as is.

@1st1
Copy link
Member

1st1 commented Mar 18, 2019

Hm, I guess only release manager can merge this in 3.6 now...

@ned-deily
Copy link
Member

3.6 is now in security-fix only support mode. As it does not appear that this change meets the criteria for inclusion in a security-fix-only branch, I am closing the PR.

@ned-deily ned-deily closed this May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 approved these changes

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fantix @1st1 @ned-deily @the-knights-who-say-ni @bedevere-bot