Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36272: Logging ignore recursion error #12312

Merged
merged 3 commits into from
Mar 15, 2019
Merged

bpo-36272: Logging ignore recursion error #12312

merged 3 commits into from
Mar 15, 2019

Conversation

remilapeyre
Copy link
Contributor

@remilapeyre remilapeyre commented Mar 13, 2019 •
edited by bedevere-bot
Loading

vsajip
vsajip requested changes Mar 14, 2019
View reviewed changes
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@remilapeyre
Copy link
Contributor Author

Hi @vsajip, I have made the requested changes; please review again :)

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@vsajip vsajip merged commit 65f64b1 into python:master Mar 15, 2019
@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12339 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 15, 2019
@miss-islington
bpo-36272: Logging now propagates RecursionError (pythonGH-12312)
741e639 
(cherry picked from commit 65f64b1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
@vsajip
Copy link
Member

vsajip commented Mar 18, 2019

@Mariatta Any idea what's happened to the 3.7 PR? There doesn't seem to have been one created.

@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @remilapeyre for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-12391 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2019
@miss-islington
bpo-36272: Logging now propagates RecursionError (pythonGH-12312)
bac23e3 
(cherry picked from commit 65f64b1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
vsajip pushed a commit that referenced this pull request Mar 18, 2019
@miss-islington @vsajip
bpo-36272: Logging now propagates RecursionError (GH-12312) (GH-12391)
6a7a9f1 
(cherry picked from commit 65f64b1)

Co-authored-by: Rémi Lapeyre <remi.lapeyre@henki.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsajip vsajip vsajip approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@remilapeyre @bedevere-bot @miss-islington @vsajip @ned-deily @Mariatta @the-knights-who-say-ni