gh-122981: Fix inspect.getsource() for generated classes with Python base classes #123001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython base classes Look up __firstlineno__ only in the class' dict, without searching in base classes.
serhiy-storchaka
force-pushed
the
inspect-getsource
branch
from
6ee8a73 to
36e96ba
Compare
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 20, 2024
…ython base classes (pythonGH-123001) Look up __firstlineno__ only in the class' dict, without searching in base classes. (cherry picked from commit f88c14d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-123182 is a backport of this pull request to the 3.13 branch. |
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…ython base classes (pythonGH-123001) Look up __firstlineno__ only in the class' dict, without searching in base classes.
Yhg1s
pushed a commit
that referenced
this pull request
Sep 2, 2024
…Python base classes (GH-123001) (#123182) gh-122981: Fix inspect.getsource() for generated classes with Python base classes (GH-123001) Look up __firstlineno__ only in the class' dict, without searching in base classes. (cherry picked from commit f88c14d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look up
__firstlineno__only in the class' dict, without searching in base classes.inspect.getsource()returns incorrect source code #122981