Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-122560: add test that comprehension loop var appears only in one scope of the symtable #122582

Merged
merged 1 commit into from
Aug 2, 2024
Merged

gh-122560: add test that comprehension loop var appears only in one scope of the symtable #122582

merged 1 commit into from
Aug 2, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 1, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 1, 2024
Closed
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Aug 1, 2024
@carljm
Copy link
Member

carljm commented Aug 2, 2024

Thanks for cleaning up this missing test coverage!

@iritkatriel iritkatriel merged commit fe0a28d into python:main Aug 2, 2024
37 checks passed
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@iritkatriel @brandtbucher
pythongh-122560: add test that comprehension loop var appears only in…
29952e5 
… one scope of the symtable (python#122582)
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@iritkatriel @blhsing
pythongh-122560: add test that comprehension loop var appears only in…
1a51e92 
… one scope of the symtable (python#122582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljm carljm carljm approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

inlined comprehension implementation in symtable - missing test or redundant code
2 participants
@iritkatriel @carljm