-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-122450: Fix docs to state denominator positivity of Fraction #122464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
privet-kitty
wants to merge
11
commits into
python:main
Choose a base branch
from
privet-kitty:feature/denominator-positivity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
04056ff
Fix manual to state denominator positivity of Fraction
privet-kitty e5a4608
Update Doc/library/fractions.rst
privet-kitty 05c764d
Add docstrings to numerator and denominator of Fraction
privet-kitty ad66afb
Correct a word
privet-kitty 416b9cd
Update Lib/fractions.py
privet-kitty 7cb1905
Update Lib/fractions.py
privet-kitty ddec59c
Update Lib/fractions.py
privet-kitty ed48fb7
Update Doc/library/fractions.rst
privet-kitty c575b47
Add docstrings to numerator and denominator of Rational
privet-kitty a531cb6
Update Lib/fractions.py
privet-kitty 1f2519a
Update Lib/fractions.py
privet-kitty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -121,12 +121,11 @@ another rational number, or from a string. | |||||
|
||||||
.. attribute:: numerator | ||||||
|
||||||
Numerator of the Fraction in lowest term. | ||||||
Numerator of the Fraction in lowest terms. | ||||||
|
||||||
.. attribute:: denominator | ||||||
|
||||||
Denominator of the Fraction in lowest term. | ||||||
|
||||||
Positive denominator of the Fraction in lowest terms. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
.. method:: as_integer_ratio() | ||||||
|
||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -297,11 +297,13 @@ class Rational(Real): | |||||
@property | ||||||
@abstractmethod | ||||||
def numerator(self): | ||||||
"""The numerator of a rational number in lowest terms.""" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
raise NotImplementedError | ||||||
|
||||||
@property | ||||||
@abstractmethod | ||||||
def denominator(self): | ||||||
"""The (positive) denominator of a rational number in lowest terms.""" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
raise NotImplementedError | ||||||
|
||||||
# Concrete implementation of Real's conversion to float. | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.