Skip to content

gh-122450: Fix docs to state denominator positivity of Fraction #122464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
5 changes: 2 additions & 3 deletions Doc/library/fractions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,11 @@ another rational number, or from a string.

.. attribute:: numerator

Numerator of the Fraction in lowest term.
Numerator of the Fraction in lowest terms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Numerator of the Fraction in lowest terms.
Numerator of the Fraction, expressed in its lowest terms.


.. attribute:: denominator

Denominator of the Fraction in lowest term.

Positive denominator of the Fraction in lowest terms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Positive denominator of the Fraction in lowest terms.
Positive denominator of the Fraction, expressed in its lowest terms.


.. method:: as_integer_ratio()

Expand Down
2 changes: 2 additions & 0 deletions Lib/numbers.py
Original file line number Diff line number Diff line change
Expand Up @@ -297,11 +297,13 @@ class Rational(Real):
@property
@abstractmethod
def numerator(self):
"""The numerator of a rational number in lowest terms."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""The numerator of a rational number in lowest terms."""
"""The numerator of a rational number, expressed in its lowest terms."""

raise NotImplementedError

@property
@abstractmethod
def denominator(self):
"""The (positive) denominator of a rational number in lowest terms."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""The (positive) denominator of a rational number in lowest terms."""
"""The (positive) denominator of a rational number, expressed in its lowest terms."""

raise NotImplementedError

# Concrete implementation of Real's conversion to float.
Expand Down
Loading