gh-121404: move calculation of module start location from compiler_body up to compiler_codegen #122127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler_body up to compiler_codegen
iritkatriel
commented
Jul 22, 2024
| @@ -1151,9 +1151,6 @@ compiler_enter_scope(struct compiler *c, identifier name, int scope_type, | |||
| } | |||
| ADDOP_I(c, loc, RESUME, RESUME_AT_FUNC_START); | |||
|
|
|||
| if (u->u_scope_type == COMPILER_SCOPE_MODULE) { | |||
| loc.lineno = -1; | |||
| } | |||
There was a problem hiding this comment.
This is not doing anything - loc is a local variable and we're exiting the function.
JelleZijlstra
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the calculation of the start location of a module to
compiler_codegen, which is the entry point, fromcompiler_body, which is also called recursively. The former will be a "compiler" function and the latter a "codegen" function once the #121404 refactor is complete.