Skip to content

gh-120811: Fix reference leak upon _PyContext_Exit failure #120812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 21, 2024
Merged

gh-120811: Fix reference leak upon _PyContext_Exit failure #120812

merged 6 commits into from
Jun 21, 2024

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Jun 20, 2024 •
edited by Eclips4
Loading

@ZeroIntensity ZeroIntensity requested a review from 1st1 as a code owner June 20, 2024 20:57
@ghost
Copy link

ghost commented Jun 20, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Jun 20, 2024
Closed
@bedevere-app
Copy link

bedevere-app bot commented Jun 20, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4 Eclips4 added skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jun 20, 2024
@AraHaan
Copy link
Contributor

AraHaan commented Jun 20, 2024 •
edited
Loading

can this be backported to the 3.11 branch but require people who want the fix to manually compile themselves as well?

@Eclips4
Copy link
Member

Eclips4 commented Jun 21, 2024

can this be backported to the 3.11 branch but require people who want the fix to manually compile themselves as well?

Unfortunately, no. 3.11 branch accepts now only a security fixes.

kumaraditya303
kumaraditya303 requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a news entry, it is a user facing bug not internal.

@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZeroIntensity
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

Thanks for making the requested changes!

@kumaraditya303: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from kumaraditya303 June 21, 2024 14:33
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) June 21, 2024 17:05
@kumaraditya303 kumaraditya303 merged commit aed31be into python:main Jun 21, 2024
37 of 38 checks passed
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2024
@ZeroIntensity @kumaraditya303 @miss-islington
pythongh-120811: Fix reference leak upon _PyContext_Exit failure (p…
680e76d 
…ythonGH-120812)

(cherry picked from commit aed31be)

Co-authored-by: Peter <zintensitydev@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

GH-120843 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2024
@ZeroIntensity @kumaraditya303 @miss-islington
pythongh-120811: Fix reference leak upon _PyContext_Exit failure (p…
1d6ab56 
…ythonGH-120812)

(cherry picked from commit aed31be)

Co-authored-by: Peter <zintensitydev@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 21, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 21, 2024

GH-120844 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 21, 2024
@ZeroIntensity ZeroIntensity deleted the patch-1 branch June 21, 2024 19:06
kumaraditya303 added a commit that referenced this pull request Jun 22, 2024
@miss-islington @ZeroIntensity @kumaraditya303
[3.12] gh-120811: Fix reference leak upon _PyContext_Exit failure (G…
b1bccab 
…H-120812) (#120844)

gh-120811: Fix reference leak upon `_PyContext_Exit` failure (GH-120812)
(cherry picked from commit aed31be)

Co-authored-by: Peter <zintensitydev@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
kumaraditya303 added a commit that referenced this pull request Jun 22, 2024
@miss-islington @ZeroIntensity @kumaraditya303
[3.13] gh-120811: Fix reference leak upon _PyContext_Exit failure (G…
a860b1d 
…H-120812) (#120843)

gh-120811: Fix reference leak upon `_PyContext_Exit` failure (GH-120812)
(cherry picked from commit aed31be)

Co-authored-by: Peter <zintensitydev@gmail.com>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@ZeroIntensity @kumaraditya303 @mrahtz
pythongh-120811: Fix reference leak upon _PyContext_Exit failure (p…
e6c583d 
…ython#120812)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@ZeroIntensity @kumaraditya303 @noahbkim
pythongh-120811: Fix reference leak upon _PyContext_Exit failure (p…
62b3b0d 
…ython#120812)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@ZeroIntensity @kumaraditya303 @estyxx
pythongh-120811: Fix reference leak upon _PyContext_Exit failure (p…
506c2f6 
…ython#120812)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeroIntensity @AraHaan @Eclips4 @kumaraditya303