Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117953: Skip test_interpreters properly without GIL #120689

Merged
merged 1 commit into from
Jun 18, 2024
Merged

gh-117953: Skip test_interpreters properly without GIL #120689

merged 1 commit into from
Jun 18, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Jun 18, 2024 •
edited by bedevere-app bot
Loading 

0:00:33 load avg: 2.57 [ 61/478] test_interpreters ran no tests -- running (1): test_subprocess (31.8 sec)
----------------------------------------------------------------------
Ran 0 tests in 0.000s

NO TESTS RAN

@bedevere-app bedevere-app bot mentioned this pull request Jun 18, 2024
Open
@nineteendo
Copy link
Contributor Author

cc @vstinner

@vstinner
Copy link
Member

Can you please elaborate?

@nineteendo
Copy link
Contributor Author

nineteendo commented Jun 18, 2024 •
edited
Loading

Same issue as here: #120660 (comment). test_interpreters isn't skipped properly:

1 test run no tests:
    test_interpreters

This is distracting when reading through the logs and the same change you asked me to make (mine didn't even work).

ericsnowcurrently
ericsnowcurrently approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FWIW, the skipping should be removed in the near future. (See #117953 (comment).) However, fixing this in the meantime makes sense.

@vstinner vstinner enabled auto-merge (squash) June 18, 2024 15:07
@vstinner
Copy link
Member

Should the change be backported to the 3.13 branch?

@nineteendo

This comment was marked as outdated.

Sign in to view
@vstinner vstinner merged commit 1035fe0 into python:main Jun 18, 2024
35 checks passed
@vstinner
Copy link
Member

Merged, thanks.

@nineteendo nineteendo deleted the skip-test_interpreters-without-gil branch June 18, 2024 15:30
@ericsnowcurrently
Copy link
Member

gh-118157 was merged before the feature freeze, thus it is part of the 3.13 branch. Backporting this would make sense.

@ericsnowcurrently ericsnowcurrently added the needs backport to 3.13 bugs and security fixes label Jun 18, 2024
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2024
@nineteendo @miss-islington
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
37e8945 
…nGH-120689)

(cherry picked from commit 1035fe0)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 18, 2024

GH-120707 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 18, 2024
@nineteendo
Copy link
Contributor Author

nineteendo commented Jun 18, 2024 •
edited
Loading

Hmm, should we include the version in the title of all pull requests? [3.14] gh-117953: Skip `test_interpreters` properly without GIL. That would make it easier to determine in which version something was added.

ericsnowcurrently pushed a commit that referenced this pull request Jun 18, 2024
@miss-islington @nineteendo
[3.13] gh-117953: Skip test_interpreters properly without GIL (gh-1…
07145dd 
…20707)

(cherry picked from commit 1035fe0, AKA gh-120689)

Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@ericsnowcurrently
Copy link
Member

I'm not sure it would be worth it. The time interval in which there's any uncertainty is relatively small and the target version for a PR against main can shift depending on how long its open. It isn't too hard to see if a commit (from a PR) is included in a specific release branch (or tag).

@nineteendo
Copy link
Contributor Author

OK, probably not worth it. I just feel bad for making a mistake because of it.

@ericsnowcurrently
Copy link
Member

There's nothing to feel bad about! We figured it out pretty quickly and even if we hadn't, it wouldn't have been a big deal.

picnixz pushed a commit to picnixz/cpython that referenced this pull request Jun 19, 2024
@nineteendo @picnixz
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
145a126 
…n#120689)
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@nineteendo @mrahtz
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
e5e61ea 
…n#120689)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@nineteendo @noahbkim
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
064368c 
…n#120689)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@nineteendo @estyxx
pythongh-117953: Skip test_interpreters properly without GIL (pytho…
69c6157 
…n#120689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nineteendo @vstinner @ericsnowcurrently