gh-120674: protect multi-line macro expansions in Modules/_testbuffer.c and Modules/_testcapimodule.c
#120675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
commented
Jun 18, 2024
vstinner
approved these changes
Jun 18, 2024
I applied my minor suggestion and enabled automerge. |
|
Thank you for the consistency nitpick! Some parts of the code align the '\' and others don't. In this PR, I tried not to align the '\' except when they are used for breaking the same expression (e.g., a function call) (but I tried to reduce the diff as much as possible). So thank you! By the way, in the future, I don't mind people comitting directly onto my branch if I don't reply directly. |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Jun 19, 2024
…capimodule.c (python#120675) Add do { ... } while (0) pattern.
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…capimodule.c (python#120675) Add do { ... } while (0) pattern.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…capimodule.c (python#120675) Add do { ... } while (0) pattern.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…capimodule.c (python#120675) Add do { ... } while (0) pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(skip news is needed for this one)
_test*.cfiles #120674