-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120662: improve smtplib
example
#120668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not an email expert, so I'll leave it a few days before merging in case anybody else wants to chime in 👍
(Feel free to ping me if it's been a week and I've forgotten!)
Thank you Alex & Hugo for your comments by the way! at the beginning, I should either have left out any stylistic changes (e.g., PEP 8 / f-strings etc) and focused on fixing the EOF-issue or should have been more consistent with the remaining style! |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
By the way, I left out the context-manager usage, but I can put it (though, for a "simple example" maybe the explicit constructions are easier to follow for a beginner) |
(cherry picked from commit 4bc27ab) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 4bc27ab) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
GH-120681 is a backport of this pull request to the 3.13 branch. |
GH-120682 is a backport of this pull request to the 3.12 branch. |
Merged, thanks @picnixz. |
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Credits to #120662 (comment).
📚 Documentation preview 📚: https://cpython-previews--120668.org.readthedocs.build/