Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120433: Mention chocolatey for installing llvm on Windows as an alternative option #120434

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jun 12, 2024

@Eclips4
Copy link
Member Author

Eclips4 commented Jun 12, 2024

cc @savannahostrowski
I guess there's something gone wrong with our CI. Previously we decided to ignore changes in *.md files to avoid wasting CI time, but actually, it's running!

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
Copy link
Member

hugovk commented Jun 12, 2024

I guess there's something gone wrong with our CI. Previously we decided to ignore changes in *.md files to avoid wasting CI time, but actually, it's running!

This is the run: https://github.com/python/cpython/actions/runs/9489036340

I don't know why, but it's because the workflow file used for the run doesn't contain the '!**/*.md' exceptions: https://github.com/python/cpython/actions/runs/9489036340/workflow

Which were added in #119147 and are still in main: https://github.com/python/cpython/blob/main/.github/workflows/jit.yml

@Eclips4
Copy link
Member Author

Eclips4 commented Jun 12, 2024

I guess there's something gone wrong with our CI. Previously we decided to ignore changes in *.md files to avoid wasting CI time, but actually, it's running!

This is the run: https://github.com/python/cpython/actions/runs/9489036340

I don't know why, but it's because the workflow file used for the run doesn't contain the '!**/*.md' exceptions: https://github.com/python/cpython/actions/runs/9489036340/workflow

Which were added in #119147 and are still in main: https://github.com/python/cpython/blob/main/.github/workflows/jit.yml

I've created #120435 to try to fix that.
Actually, what do you mean when you say "but it's because the workflow file used for the run doesn't contain the '!**/*.md' exceptions:"? I'm seeing that:

name: JIT
on:
  pull_request:
    paths:
      - '!**/*.md'
      - '!**/*.ini'
      - '**jit**'
      - 'Python/bytecodes.c'
      - 'Python/optimizer*.c'
      - '!Python/perf_jit_trampoline.c'
  push:
    paths:
      - '!**/*.md'
      - '!**/*.ini'
      - '**jit**'
      - 'Python/bytecodes.c'
      - 'Python/optimizer*.c'
      - '!Python/perf_jit_trampoline.c'

@hugovk
Copy link
Member

hugovk commented Jun 12, 2024

So it does... I missed them because the PR added them to the end of the lists, not the top: 🤔

       - '**jit**'
       - 'Python/bytecodes.c'
       - 'Python/optimizer*.c'
+      - '!Python/perf_jit_trampoline.c'
+      - '!**/*.md'
+      - '!**/*.ini'
   push:
     paths:
       - '**jit**'
       - 'Python/bytecodes.c'
       - 'Python/optimizer*.c'
+      - '!Python/perf_jit_trampoline.c'
+      - '!**/*.md'
+      - '!**/*.ini'

I wonder why they're different.

Alternatively, you can use [chocolatey](https://chocolatey.org):

```sh
choco install llvm --version=18.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify just --version=18, without minor and patch releases? Other tools do not specify exact version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to specify just --version=18, without minor and patch releases? Other tools do not specify exact version.

Unfortunately, no.
We can also omit --version and the latest stable release will be installed. What do you think about that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to stick to a version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, here's the list of available versions:

llvm 18.1.6 [Approved] Downloads cached for licensed users
llvm 18.1.5 [Approved] Downloads cached for licensed users
llvm 18.1.4 [Approved] Downloads cached for licensed users
llvm 18.1.3 [Approved]
llvm 18.1.2 [Approved]
llvm 18.1.0 [Approved] Downloads cached for licensed users

Which one do you prefer? The latest one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest, yes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would have to update it from time to time, but there's no other way, I guess ;)

Thanks!

@sobolevn sobolevn enabled auto-merge (squash) June 17, 2024 15:51
@sobolevn sobolevn merged commit 95737bb into python:main Jun 17, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2024
…s as an alternative option (pythonGH-120434)

(cherry picked from commit 95737bb)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-app bot commented Jun 17, 2024

GH-120651 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 17, 2024
@Eclips4 Eclips4 deleted the issue-120433 branch June 17, 2024 15:59
sobolevn pushed a commit that referenced this pull request Jun 17, 2024
…ws as an alternative option (GH-120434) (#120651)

gh-120433: Mention ``chocolatey`` for installing llvm on Windows as an alternative option (GH-120434)
(cherry picked from commit 95737bb)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants