Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120029: remove unused macros in symtable.c #120222

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 7, 2024

- remove ``DEF_FREE``
- remove ``GENERATOR``
- remove ``GENERATOR_EXPRESSION``
@carljm carljm enabled auto-merge (squash) June 11, 2024 14:53
@carljm carljm disabled auto-merge June 11, 2024 15:17
@carljm carljm closed this Jun 11, 2024
@carljm carljm reopened this Jun 11, 2024
@picnixz
Copy link
Member Author

picnixz commented Jun 12, 2024

@carljm In the future, do you want me to ping you when I'm making changes to symtable-related code?

@carljm
Copy link
Member

carljm commented Jun 12, 2024

I'm listed in CODEOWNERS for it, so I'll get added as a reviewer automatically.

@carljm carljm merged commit 32d3e05 into python:main Jun 12, 2024
34 checks passed
@picnixz picnixz deleted the only-deprecate-def-free-symtable branch June 15, 2024 14:24
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
Co-authored-by: Carl Meyer <carl@oddbird.net>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
Co-authored-by: Carl Meyer <carl@oddbird.net>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Co-authored-by: Carl Meyer <carl@oddbird.net>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants