gh-120041: Do not use append_to_screen when completions are visible #120042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lysnikolaou
commented
Jun 4, 2024
•
lysnikolaou
commented
- Issue: PyREPL: Completion menu does not get updated when inserting a character #120041
2 tasks
lysnikolaou
added
needs backport to 3.13
|
Thanks @lysnikolaou for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 4, 2024
…ible (pythonGH-120042) (cherry picked from commit 8fc7653) Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
|
GH-120051 is a backport of this pull request to the 3.13 branch. |
lysnikolaou
added a commit
that referenced
this pull request
Jun 4, 2024
…sible (GH-120042) (#120051) * gh-120041: Do not use append_to_screen when completions are visible (GH-120042) (cherry picked from commit 8fc7653) * gh-120041: Refactor check for visible completion menu in completing_reader (GH-120055) (cherry picked from commit bf8e5e5) --------- Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.