gh-118835: pyrepl: Fix prompt length computation for custom prompts containing ANSI escape codes #119942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
AlexWaygood
added
needs backport to 3.13
pablogsal
approved these changes
Jun 3, 2024
|
Thanks a lot for catching this and for the PR @danielhollas ! |
|
Thanks @danielhollas for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 3, 2024
…mpts containing ANSI escape codes (pythonGH-119942) (cherry picked from commit 2e0aa73) Co-authored-by: Daniel Hollas <daniel.hollas@bristol.ac.uk>
|
GH-119990 is a backport of this pull request to the 3.13 branch. |
mliezun
pushed a commit
to mliezun/cpython
that referenced
this pull request
Jun 3, 2024
…mpts containing ANSI escape codes (python#119942)
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
…mpts containing ANSI escape codes (python#119942)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…mpts containing ANSI escape codes (python#119942)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…mpts containing ANSI escape codes (python#119942)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prompt length computation in
Reader.process_promptwas broken since it used thewlenfunction from utils, but thewlenfunction already excluded the ANSI codes, which broke the existing logic.The logic in that function could probably use some refactoring, but I wasn't confident in doing it due to its complexity. So I simply patched the wlen function locally. Happy to consider different approach.
Closes #118835.