Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-118507 : Speed up ntpath.isjunction() & ntpath.lexists() with native helpers (GH-118755) #119420

Closed

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented May 22, 2024

@nineteendo
Copy link
Contributor Author

nineteendo commented May 22, 2024

@zooba, add "DO-NOT-MERGE" until we're more confident?

@nineteendo nineteendo changed the title [3.12] gh-118507 : Refactor nt._path_is* to improve applicability for other cases (GH-118755) [3.12] gh-118507 : Speed up ntpath.isjunction() & ntpath.lexists() with native helpers (GH-118755) May 27, 2024
@hugovk
Copy link
Member

hugovk commented Aug 9, 2024

Triage: closing because the parent issue has since been closed, and there's been no more discussion since this was opened. Please let me know if it should stay open.

@hugovk hugovk closed this Aug 9, 2024
@zooba zooba reopened this Aug 9, 2024
@zooba
Copy link
Member

zooba commented Aug 9, 2024

Was going to say we should take it now that 3.13.0rc1 has gone out without issue, but I don't actually want to run afoul of the people who say not to put perf improvements into 3.12. So let's just leave it.

@zooba zooba closed this Aug 9, 2024
@nineteendo nineteendo deleted the backport-b641825-3.12-part2 branch August 9, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants