Skip to content

gh-118836: Fix JIT build error when SHT_NOTE section is present #119000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2024
Merged

gh-118836: Fix JIT build error when SHT_NOTE section is present #119000

merged 1 commit into from
May 13, 2024

Conversation

@mgorny
Copy link
Contributor

@mgorny mgorny commented May 13, 2024 •
edited by bedevere-app bot
Loading

Fix an AssertionError when building with --enable-experimental-jit and the compiler emits a SHT_NOTE section.

@mgorny mgorny requested a review from brandtbucher as a code owner May 13, 2024 13:59
@bedevere-app bedevere-app bot mentioned this pull request May 13, 2024
Closed
@brandtbucher brandtbucher self-assigned this May 13, 2024
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error build The build process and cross-build needs backport to 3.13 bugs and security fixes labels May 13, 2024
brandtbucher
brandtbucher approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@brandtbucher brandtbucher merged commit e04cd96 into python:main May 13, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented May 13, 2024

Thanks @mgorny for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 13, 2024
@mgorny @miss-islington
pythonGH-118836: Fix JIT build error when SHT_NOTE section is present (…
e257f51 
…pythonGH-119000)

(cherry picked from commit e04cd96)

Co-authored-by: Michał Górny <mgorny@gentoo.org>
@bedevere-app
Copy link

bedevere-app bot commented May 13, 2024

GH-119020 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 13, 2024
@mgorny
Copy link
Contributor Author

mgorny commented May 14, 2024

Thanks!

@mgorny mgorny deleted the jit-sht_note branch May 14, 2024 04:54
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@mgorny @estyxx
pythonGH-118836: Fix JIT build error when SHT_NOTE section is present (…
2743976 
…pythonGH-119000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@brandtbucher brandtbucher

Labels

build The build process and cross-build topic-JIT type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mgorny @brandtbucher