-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-118039: Fix config.cache key on WASI #118137
Conversation
Could someone add the skip news label? Thank you. |
Do we need it for all these five files? Some of them build their own Python and don't use |
Ah, I see. I've added a comment to clarify why we need them for |
I think that explains why it only failed on WASI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
(cc @erlend-aasland in case you wanted to check)
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Backport: we don't have Thank you @nineteendo! 🚀 |
We need to include the current python version in the config.cache key.
Otherwise the build can fail with an error like this: