-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-117995: Don't raise DeprecationWarnings for indexed nameless params #118001
gh-117995: Don't raise DeprecationWarnings for indexed nameless params #118001
Conversation
… params Filter out '?NNN' type placeholders when looking for named params.
cc. @kalekundert |
@aisk, would you like to review this? |
I'll merge this early next week. Thanks for chiming in, @aisk :) |
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Thank you so much, @aisk! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erlend-aasland Thanks 👍 Looks good 🚀
Thanks for the review, Mariusz! |
This comment was marked as outdated.
This comment was marked as outdated.
… params (pythonGH-118001) Filter out '?NNN' placeholders when looking for named params. (cherry picked from commit 550483b) Co-authored-by: Erlend E. Aasland <erlend@python.org> Co-authored-by: AN Long <aisk@users.noreply.github.com>
GH-118142 is a backport of this pull request to the 3.12 branch. |
|
Filter out
?NNN
type placeholders when looking for named params.?1
a named placeholder #117995