Skip to content

gh-102402: Fix logging test_relativeCreated_has_higher_precision() leak #117985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2024
Merged

gh-102402: Fix logging test_relativeCreated_has_higher_precision() leak #117985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2529340
gh-102402: Fix logging test_relativeCreated_has_higher_precision() leak
vstinner Apr 17, 2024
8393041
Add @cpython_only decorator
vstinner Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4569,27 +4569,25 @@ def test_msecs_has_no_floating_point_precision_loss(self):
self.assertEqual(record.msecs, want)
self.assertEqual(record.created, ns / 1e9)

# The test overrides a private attribute
@support.cpython_only
def test_relativeCreated_has_higher_precision(self):
# See issue gh-102402
ns = 1_677_903_920_000_998_503 # approx. 2023-03-04 04:25:20 UTC
offsets_ns = (200, 500, 12_354, 99_999, 1_677_903_456_999_123_456)
orig_modules = import_helper._save_and_remove_modules(['logging'])
try:
with patch("time.time_ns") as patched_ns:
# mock for module import
patched_ns.return_value = ns
import logging
for offset_ns in offsets_ns:
new_ns = ns + offset_ns
# mock for log record creation
patched_ns.return_value = new_ns
record = logging.makeLogRecord({'msg': 'test'})
self.assertAlmostEqual(record.created, new_ns / 1e9, places=6)
# After PR gh-102412, precision (places) increases from 3 to 7
self.assertAlmostEqual(record.relativeCreated, offset_ns / 1e6, places=7)
finally:
import_helper._save_and_remove_modules(['logging'])
sys.modules.update(orig_modules)

with (patch("time.time_ns") as time_ns_mock,
support.swap_attr(logging, '_startTime', ns)):
for offset_ns in offsets_ns:
# mock for log record creation
new_ns = ns + offset_ns
time_ns_mock.return_value = new_ns

record = logging.makeLogRecord({'msg': 'test'})
self.assertAlmostEqual(record.created, new_ns / 1e9, places=6)

# After PR gh-102412, precision (places) increases from 3 to 7
self.assertAlmostEqual(record.relativeCreated, offset_ns / 1e6, places=7)


class TestBufferingFormatter(logging.BufferingFormatter):
Expand Down