Skip to content

gh-115664: Fix ordering of more versionadded and versionchanged directives #116298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

gh-115664: Fix ordering of more versionadded and versionchanged directives #116298

merged 2 commits into from
Mar 7, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 4, 2024 •
edited
Loading

@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 4, 2024
@bedevere-app bedevere-app bot mentioned this pull request Mar 4, 2024
Closed
gpshead
gpshead approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this seems consistent and a good cleanup. A few comments on philosophy, but don't consider them blockers. I think the docs are good with this change regardless.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 4, 2024
Merged
@rhettinger rhettinger removed their request for review March 4, 2024 13:59
@brettcannon brettcannon removed their request for review March 4, 2024 19:55
@serhiy-storchaka serhiy-storchaka merged commit 808a776 into python:main Mar 7, 2024
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the docs-versionmodified-reorder branch March 7, 2024 08:05
@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 808a77612fb89b125d25efac2788522a100e8a6d 3.12

@miss-islington-app
Copy link

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 808a77612fb89b125d25efac2788522a100e8a6d 3.11

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 7, 2024
@serhiy-storchaka
[3.12] pythongh-115664: Fix ordering of more versionadded and version…
595cbfc 
…changed directives (pythonGH-116298)

(cherry picked from commit 808a776)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 7, 2024

GH-116450 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 7, 2024
serhiy-storchaka added a commit that referenced this pull request Mar 7, 2024
@serhiy-storchaka
[3.12] gh-115664: Fix ordering of more versionadded and versionchange…
1e75fe1 
…d directives (GH-116298) (GH-116450)

(cherry picked from commit 808a776)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Mar 7, 2024
@serhiy-storchaka
[3.11] [3.12] pythongh-115664: Fix ordering of more versionadded and …
2eb65bb 
…versionchanged directives (pythonGH-116298) (pythonGH-116450)

(cherry picked from commit 1e75fe1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 808a776)
serhiy-storchaka added a commit that referenced this pull request Mar 7, 2024
@serhiy-storchaka
[3.11] gh-115664: Fix ordering of more versionadded and versionchange…
e89f2a0 
…d directives (GH-116298) (GH-116450) (GH-116452)

(cherry picked from commit 1e75fe1)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
(cherry picked from commit 808a776)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@serhiy-storchaka @adorilson
pythongh-115664: Fix ordering of more versionadded and versionchanged…
d757e82 
… directives (pythonGH-116298)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@serhiy-storchaka @diegorusso
pythongh-115664: Fix ordering of more versionadded and versionchanged…
338aa4e 
… directives (pythonGH-116298)
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.11 only security fixes label Sep 29, 2024
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @gpshead