Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35790: Correct the description of sys.exc_info() and add a code example #11625

Merged
merged 12 commits into from
Dec 21, 2020
Merged

bpo-35790: Correct the description of sys.exc_info() and add a code example #11625

merged 12 commits into from
Dec 21, 2020

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Jan 20, 2019 •
edited
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 20, 2019
eamanu
eamanu reviewed Jan 20, 2019
View reviewed changes
Doc/reference/compound_stmts.rst Outdated Show resolved Hide resolved
Doc/reference/compound_stmts.rst Outdated Show resolved Hide resolved
Doc/reference/compound_stmts.rst Outdated Show resolved Hide resolved
@JulienPalard
Copy link
Member

Hi @maggyero thanks for the PR!

Can you please not rewrap the whole file? We like to keep the history clean and readable by only making atomic modifications.

Don't hesitate to simply git revert the formatting commit and push the revert, no push force needed, anyway all commits will be squashed right before merging so those "back and forth" will disapear and the history will remain clean with only the sentence updated.

(dropping the comit by rebaseing around it and push force will do too if you feel more confortable like this).

@geryogam
Copy link
Contributor Author

Can you please not rewrap the whole file?

@JulienPalard Yes, done.

@geryogam
Copy link
Contributor Author

geryogam commented Sep 3, 2019

@JulienPalard I have made the requested changes. Please review again.

@JulienPalard
Copy link
Member

I would like for a native english speaker to review the posessive modifications, I'm not a big fan of this change (but I'm french...).

@maggyero this PR could have been merged more easily if it focused on a single thing (fixing the exc_info value restoration doc).

@iritkatriel
Copy link
Member

@maggyero Juliean made a valid point - there is scope creep in this PR. Why don't you just restrict it to the change described in the bpo ticket, and then it can be merged?

@geryogam
Copy link
Contributor Author

geryogam commented Oct 9, 2020

@iritkatriel @JulienPalard You are right, done. I have just refocused the PR (no more reformatting). This PR can be merged now.

@geryogam
Copy link
Contributor Author

geryogam commented Oct 9, 2020

@iritkatriel Thanks for reviewing this.

iritkatriel
iritkatriel requested changes Oct 9, 2020
View reviewed changes
Doc/reference/compound_stmts.rst Outdated Show resolved Hide resolved
@geryogam geryogam changed the title bpo-35790: Correct a statement about sys.exc_info() values restoration in the docs bpo-35790: Correct the description of sys.exc_info() and add a code example Oct 9, 2020
@JulienPalard JulienPalard reopened this Dec 18, 2020
eamanu
eamanu approved these changes Dec 19, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@JulienPalard JulienPalard merged commit d515c61 into python:master Dec 21, 2020
@JulienPalard
Copy link
Member

Thanks @maggyero for enhancing the doc! Appreciated! And thanks @iritkatriel and @eamanu for proofreading! Happy holidays everyone ♥

@geryogam geryogam deleted the patch-6 branch December 21, 2020 13:34
@geryogam
Copy link
Contributor Author

Thanks @JulienPalard for reviewing and merging this PR. And thanks @iritkatriel and @eamanu for reviewing this. Happy holidays!

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@geryogam @adorilson
bpo-35790: Correct the description of sys.exc_info() and add a code e…
231c220 
…xample (pythonGH-11625)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPalard JulienPalard JulienPalard left review comments

@eamanu eamanu eamanu approved these changes

@iritkatriel iritkatriel iritkatriel approved these changes

@csabella csabella Awaiting requested review from csabella

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geryogam @JulienPalard @iritkatriel @eamanu @the-knights-who-say-ni @bedevere-bot