Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-35045: Accept TLSv1 default in min max test #11510

Merged
merged 1 commit into from
Jan 18, 2019
Merged

bpo-35045: Accept TLSv1 default in min max test #11510

merged 1 commit into from
Jan 18, 2019

Conversation

tiran
Copy link
Member

@tiran tiran commented Jan 10, 2019 •
edited by bedevere-bot
Loading

Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue35045

@tiran
bpo-35045: Accept TLSv1 default in min max test
d3aae37 
Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran added needs backport to 2.7 tests Tests in the Lib/test dir labels Jan 10, 2019
@vstinner vstinner mentioned this pull request Jan 15, 2019
Closed
vstinner
vstinner approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
Copy link
Member

I tested manually and I confirm that this change fix test_ssl on my Fedora 29.

@vstinner vstinner merged commit 34de2d3 into python:master Jan 18, 2019
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11611 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Sorry, @tiran and @vstinner, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 34de2d312b3687994ddbc29adb66e88f672034c7 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 18, 2019
@tiran @miss-islington
bpo-35045: Accept TLSv1 default in min max test (pythonGH-11510)
f4e5a88 
Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 34de2d3)

Co-authored-by: Christian Heimes <christian@python.org>
@vstinner vstinner mentioned this pull request Jan 18, 2019
Closed
miss-islington added a commit that referenced this pull request Jan 18, 2019
@miss-islington @tiran
bpo-35045: Accept TLSv1 default in min max test (GH-11510)
6ca7183 
Make ssl tests less strict and also accept TLSv1 as system default. The
changes unbreaks test_min_max_version on Fedora 29.

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 34de2d3)

Co-authored-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@vstinner vstinner

Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiran @vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni