-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112388: Fix an error that was causing the parser to try to overwrite tokenizer errors #112410
Conversation
…verwrite tokenizer errors Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Maybe scope creep, but is there an opportunity for an improvement here?
|
🤖 New build scheduled with the buildbot fleet by @sunmy2019 for commit cef5ae9 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
We need a placeholder here. If you track the caller, it's like void *a;
if (all_good)
a = ...;
else
a = _PyPegen_raise_error(...); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Most of the time we assign the return value of |
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…verwrite tokenizer errors (pythonGH-112410) (cherry picked from commit 2c8b191) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
GH-112466 is a backport of this pull request to the 3.12 branch. |
…verwrite tokenizer errors (pythonGH-112410) (cherry picked from commit 2c8b191) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com> Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
GH-112467 is a backport of this pull request to the 3.11 branch. |
…verwrite tokenizer errors (python#112410) Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
…verwrite tokenizer errors (python#112410) Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Objects/call.c
:342:!_PyErr_Occurred(tstate)
failed #112388