Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized #112196

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

salty-horse
Copy link
Contributor

@salty-horse salty-horse commented Nov 17, 2023

The documentation of the deprecation of typing aliases in 3.12 (#94309) was just the names of the aliases, without a description of what happens to them. This can cause confusion, even if it's in the "Deprecated" section of documentation, since all other items include this description.

This should be backported to 3.12.


📚 Documentation preview 📚: https://cpython-previews--112196.org.readthedocs.build/

@bedevere-app bedevere-app bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 17, 2023
@AlexWaygood AlexWaygood self-requested a review November 17, 2023 10:23
@AlexWaygood AlexWaygood changed the title gh-94309: Fix documentation for deprecated aliases gh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.Sized Nov 17, 2023
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salty-horse salty-horse force-pushed the typing_deprecation_doc branch from 2f7fa98 to 5a776e7 Compare November 17, 2023 12:22
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlexWaygood AlexWaygood enabled auto-merge (squash) November 17, 2023 12:25
@AlexWaygood AlexWaygood self-assigned this Nov 17, 2023
@AlexWaygood AlexWaygood merged commit fb4cddb into python:main Nov 17, 2023
@miss-islington-app
Copy link

Thanks @salty-horse for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2023
…ce for typing.Hashable and typing.Sized (pythonGH-112196)

(cherry picked from commit fb4cddb)

Co-authored-by: Ori Avtalion <ori@avtalion.name>
@bedevere-app
Copy link

bedevere-app bot commented Nov 17, 2023

GH-112200 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 17, 2023
AlexWaygood pushed a commit that referenced this pull request Nov 17, 2023
…ice for typing.Hashable and typing.Sized (GH-112196) (#112200)

gh-94309: "What's new in Python 3.12": improve deprecation notice for typing.Hashable and typing.Sized (GH-112196)
(cherry picked from commit fb4cddb)

Co-authored-by: Ori Avtalion <ori@avtalion.name>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants