Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-96954: Fix make regen-unicodedata in out-of-tree builds #112118

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented Nov 15, 2023

This avoids:

python3.13 Tools/unicode/makeunicodedata.py
python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
make: *** [Makefile:1498: regen-unicodedata] Error 2

This avoids:

    python3.13 Tools/unicode/makeunicodedata.py
    python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
    make: *** [Makefile:1498: regen-unicodedata] Error 2
@vstinner
Copy link
Member

I confirm that the fix works as expected, there is no error:

git pr 112118

git clean -fdx
mkdir WORKDIR
cd WORKDIR
../configure --with-pydebug
make regen-all
make regen-unicodedata

I also tested that other regen commands don't fail:

make regen-stdlib-module-names
make regen-limited-abi
make regen-configure

@vstinner
Copy link
Member

Please run make regen-unicodedata in the source directory and include changes of generated files in your PR. See: https://github.com/python/cpython/actions/runs/6879727597/job/18712327275?pr=112118

@hroncok
Copy link
Contributor Author

hroncok commented Nov 15, 2023

There's a typo in the second commit message. I know you don't like force pushing to PRs, so please correct it when squashing.

@vstinner vstinner enabled auto-merge (squash) November 15, 2023 16:36
@vstinner vstinner merged commit ec05507 into python:main Nov 15, 2023
@hroncok hroncok deleted the out-of-tree-make-unicodedata branch November 15, 2023 16:49
@hroncok
Copy link
Contributor Author

hroncok commented Nov 15, 2023

Thanks.

@vstinner
Copy link
Member

Thanks for your fix! We test out-of-free build in the CI, but we don't run make regen-all in this out-of-tree CI job. make regen-all is tested in a CI job which don't build Python out-of-tree.

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ython#112118)

This avoids:

    python3.13 Tools/unicode/makeunicodedata.py
    python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
    make: *** [Makefile:1498: regen-unicodedata] Error 2

Re-run `make regen-unicodedata` to update the script path in generated files.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ython#112118)

This avoids:

    python3.13 Tools/unicode/makeunicodedata.py
    python3.13: can't open file '.../build/debug/Tools/unicode/makeunicodedata.py': [Errno 2] No such file or directory
    make: *** [Makefile:1498: regen-unicodedata] Error 2

Re-run `make regen-unicodedata` to update the script path in generated files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants