Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed dangling since Python at the end of library/xml.rst #11201

Merged
merged 4 commits into from
Dec 19, 2018
Merged

Removed dangling since Python at the end of library/xml.rst #11201

merged 4 commits into from
Dec 19, 2018

Conversation

Seluj78
Copy link
Contributor

@Seluj78 Seluj78 commented Dec 17, 2018

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 17, 2018
@Seluj78 Seluj78 mentioned this pull request Dec 17, 2018
Merged
@Seluj78
Copy link
Contributor Author

Seluj78 commented Dec 17, 2018

@tiran Was the since Python at the end supposed to be for something ? I just looked at the blame and you were the last one to change those lines 👍

@serhiy-storchaka
Copy link
Member

I do not know what would be better: to remove the trailing "since Python" or to remove the leading "since Python" and fix the trailing one. What looks better English?

In any case, I think it is better to replace 3.8.0 with 3.8 and add the corresponding versionchanged directive.

@Seluj78
Copy link
Contributor Author

Seluj78 commented Dec 18, 2018

I think leaving the first since Python looks better 👍

As for the versionchanged directive, I'll see what I can do 👌

@Seluj78
Copy link
Contributor Author

Seluj78 commented Dec 18, 2018

@serhiy-storchaka Is this what you wanted? 👌

@serhiy-storchaka
Copy link
Member

The versionchanged directives were added in proper places (in xml.dom.pulldom.rst and xml.sax.rst), so it is not needed here. Sorry.

@serhiy-storchaka
Copy link
Member

Just restore your initial change please.

@Seluj78
Copy link
Contributor Author

Seluj78 commented Dec 18, 2018

@serhiy-storchaka Done 👌

@serhiy-storchaka serhiy-storchaka merged commit 82d7355 into python:master Dec 19, 2018
@miss-islington
Copy link
Contributor

Thanks @Seluj78 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11231 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 19, 2018
@Seluj78 @miss-islington
Removed dangling since Python at the end of library/xml.rst. (pytho…
baa4614 
…nGH-11201)

(cherry picked from commit 82d7355)

Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
miss-islington added a commit that referenced this pull request Dec 21, 2018
@miss-islington @Seluj78
[3.7] Removed dangling since Python at the end of library/xml.rst. (G…
aa7922a 
…H-11201) (GH-11231)

(cherry picked from commit 82d7355)


Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 23, 2018
@miss-islington @Seluj78 @ned-deily
[3.7] Removed dangling since Python at the end of library/xml.rst. (p…
26c94c3 
…ythonGH-11201) (pythonGH-11231)

(cherry picked from commit 82d7355)


Co-authored-by: Jules Lasne (jlasne) <jlasne@student.42.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@Mariatta Mariatta Mariatta approved these changes

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Seluj78 @serhiy-storchaka @miss-islington @bedevere-bot @Mariatta @the-knights-who-say-ni