gh-111863: Rename Py_NOGIL to Py_GIL_DISABLED
#111864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
requested review from
FFY00,
a team,
brettcannon,
ericsnowcurrently,
ncoghlan,
warsaw,
tiran,
markshannon,
erlend-aasland and
corona10
as code owners
hugovk
removed request for
FFY00,
a team,
ericsnowcurrently,
ncoghlan,
warsaw,
tiran,
markshannon,
erlend-aasland and
corona10
|
Then I would suggest |
|
Thanks @hugovk. I would like some comment first from the Python steering council about the preferred name so that:
Beyond that, we'll also need to change |
|
The SC threw our xkcd-randomized dart at the dartboard of bikeshed names: it landed on |
hugovk
force-pushed
the
rename-Py_NOGIL
branch
from
af090d9
to
41c524d
Compare
|
Thanks, updated to use |
hugovk
changed the title
Py_NOGIL to Py_DISABLE_GILPy_NOGIL to Py_GIL_DISABLED
colesbury
approved these changes
Nov 20, 2023
scoder
pushed a commit
to cython/cython
that referenced
this pull request
Nov 20, 2023
scoder
pushed a commit
to cython/cython
that referenced
this pull request
Nov 20, 2023
|
This created a file in Misc/NEWS.d/next/C_API, presumably by accident. The actual directory should be Misc/NEWS.d/next/"C API" (a space instead of an underscore). Was the blurb file created by hand, or is this a bug in blurb or blurb-it? |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Rename Py_NOGIL to Py_GIL_DISABLED
ambv
added a commit
to python/peps
that referenced
this pull request
Mar 6, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Rename Py_NOGIL to Py_GIL_DISABLED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion for gh-111863, following the pattern of the
--disable-gilflag.cc @colesbury