bpo-34855: Correct Windows-native variables

[antektek]

Adding an extra S to "EXTERNAL_DIR" (line 27).

https://bugs.python.org/issue34855

[the-knights-who-say-ni]

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

[Mariatta]

I don't think we should make this change.

[antektek]

Hello,

I saw this issue concerning the following file : find_python.bat.
I think it is just a spelling mistake but it is possible that I misunderstand the issue.

[Mariatta]

In that case, please include the issue number in the PR title, so this PR is linked to the issue correctly. I.e. the PR title should have started with "bpo-34855: ..."
I'll let @python/windows-team to take it from here.

[ghost]

68d663c
committed Jul 17, 2017

a Member added to https://bugs.python.org/issue34855

versions: + Python 3.6, Python 3.7
nosy: + paul.moore, tim.golden, zach.ware, steve.dower

seems like someone on the Nosy List should attend to the changes where indicated

by the way, as "Report Tracker Problem" from the python bug tracker webpage is now hyperlinked to a GitHub address, someone might identify if any of the non-highlighted fields on the python bug tracker registration page are factually required (in order to receive the confirmation e-mail), and, if so, change those fields to highlighted

[ghost]

no clarification has been presented on the correctness on line 11 from

https://github.com/python/cpython/blob/master/.azure-pipelines/windows-steps.yml

Should windows-steps.yml (line 11) and windows-appx-test.yml committed 6 Dec. (line 39) both read EXTERNALS_DIR?

https://bugs.python.org/msg332572

[antektek]

Thanks for changing the title.
I am new on github and i didn't know about that.

The check about the news entry in Misc/NEWS.d/next/ is still failing.
What should I do to correct that ?

Concerning the issue, the file PCbuild/python.props contains the "variable" EXTERNALS_DIR (line 46) but EXTERNAL_DIR is defined nowhere in this file.

[ghost]

I believe 0cd6391 created windows-appx-test.yml

Which commit created windows-steps.yml?

@zooba

[antektek]

I think the commit 5767509 created windows-steps.yml.

[ghost]

in the extracted download cpython-3.6.6.zip

EXTERNAL_DIR appears in the .vsts directory

[ghost]

if modification of the additional two files

windows-appx-test.yml
windows-steps.yml

is pursued, maybe the issue should be renamed to

bpo-34855: Correct Windows-native variables

S.D. labeled issue34855 "easy" on the Python bug tracker

its not urgent, and can be postponed until the 1st quarter of 2019

I'd wait for a clarification from S.D. on the cited .yml files' content

[antektek]

I changed the title of the merge request just in case of.

[ghost]

@antektek

bedevere-bot seems to be without manners, adding hyperlinks invariably to any bugs python org issues

[zooba]

Yes, updating those two YAML files would be correct. (Though not really necessary for correct functionality, it'll help avoid the confusion of using incorrect variables.)

[zooba]

Marking this as un-NEWSworthy, since it doesn't have any impact on end-users (even those who are building from source 99% of the time).

[ghost]

The OS-windows label could be added.

[zooba]

Looks great to me. It might be time to try updating the build output location in the Pipelines builds to outside the source tree, as I think we can successfully run tests there now. But I'll give that a go.

[miss-islington]

Thanks @antektek for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

[bedevere-bot]

GH-11490 is a backport of this pull request to the 3.7 branch.

[ghost]

bpo-34855: lists 3.6

the needs backport to 3.6 label should be added

[ghost]

@zooba if no one is intending to pursue the backport to 3.6 I suppose this issue could be closed

[miss-islington]

Thanks @antektek for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington]

Sorry, @antektek and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6aedfa6b9ac324587f64133c23757a66a8f355bb 3.6

[zooba]

Let's see if the tag works.

[zooba]

No, guess not. I'll close it then :)

[zooba]

It's already closed. Please try and avoid commenting on resolved issues, and particularly on pull requests - it just creates noise that distracts us from helping actual contributions.