Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-107450: Check for overflow in the tokenizer and fix overflow test #110832

Merged
merged 6 commits into from
Oct 16, 2023
Merged

gh-107450: Check for overflow in the tokenizer and fix overflow test #110832

merged 6 commits into from
Oct 16, 2023

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Oct 13, 2023 •
edited by bedevere-app bot
Loading

@lysnikolaou lysnikolaou requested a review from ambv October 13, 2023 13:56
@bedevere-app bedevere-app bot mentioned this pull request Oct 13, 2023
Closed
2 tasks
@lysnikolaou lysnikolaou mentioned this pull request Oct 13, 2023
Closed
@lysnikolaou lysnikolaou added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Oct 13, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @lysnikolaou for commit 3036fad 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 13, 2023
@lysnikolaou @FFY00
pythongh-107450: Check for overflow in the tokenizer and fix overflow…
16d508d 
… test

Co-authored-by: Filipe Laíns <lains@riseup.net>
@lysnikolaou lysnikolaou mentioned this pull request Oct 14, 2023
Closed
serhiy-storchaka
serhiy-storchaka reviewed Oct 14, 2023
View reviewed changes
Lib/test/test_exceptions.py Outdated Show resolved Hide resolved
Lib/test/test_exceptions.py Show resolved Hide resolved
Parser/lexer/lexer.c Outdated Show resolved Hide resolved
Lib/test/test_exceptions.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed Oct 16, 2023
View reviewed changes
Lib/test/test_exceptions.py Outdated Show resolved Hide resolved
Lib/test/test_exceptions.py Outdated Show resolved Hide resolved
@lysnikolaou
Copy link
Contributor Author

@serhiy-storchaka Thanks a lot for the reviews! I've addressed all comments.

@lysnikolaou lysnikolaou merged commit a1ac559 into python:main Oct 16, 2023
27 checks passed
@miss-islington
Copy link
Contributor

Thanks @lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @lysnikolaou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a1ac5590e0f8fe008e5562d22edab65d0c1c5507 3.12

@miss-islington
Copy link
Contributor

Sorry, @lysnikolaou, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a1ac5590e0f8fe008e5562d22edab65d0c1c5507 3.11

@bedevere-app
Copy link

bedevere-app bot commented Oct 16, 2023

GH-110931 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 16, 2023
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Oct 16, 2023
@lysnikolaou @FFY00 @serhiy-storchaka
[3.12] pythongh-107450: Check for overflow in the tokenizer and fix o…
99047c0 
…verflow test (pythonGH-110832)

(cherry picked from commit a1ac559)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Filipe Laíns <lains@riseup.net>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 16, 2023

GH-110939 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 16, 2023
lysnikolaou added a commit to lysnikolaou/cpython that referenced this pull request Oct 16, 2023
@lysnikolaou @FFY00 @serhiy-storchaka
[3.11] pythongh-107450: Check for overflow in the tokenizer and fix o…
01760a7 
…verflow test (pythonGH-110832)

(cherry picked from commit a1ac559)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Filipe Laíns <lains@riseup.net>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
lysnikolaou added a commit that referenced this pull request Oct 16, 2023
@lysnikolaou @FFY00 @serhiy-storchaka
[3.12] gh-107450: Check for overflow in the tokenizer and fix overflo…
3b87e52 
…w test (GH-110832) (#110931)

(cherry picked from commit a1ac559)

Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Co-authored-by: Filipe Laíns <lains@riseup.net>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
vstinner pushed a commit that referenced this pull request Oct 17, 2023
@lysnikolaou @FFY00 @serhiy-storchaka
[3.11] gh-107450: Check for overflow in the tokenizer and fix overflo…
1af7b7d 
…w test (GH-110832) (#110939)

(cherry picked from commit a1ac559)

Co-authored-by: Filipe Laíns <lains@riseup.net>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@lysnikolaou @FFY00
@serhiy-storchaka @aisk
pythongh-107450: Check for overflow in the tokenizer and fix overflow…
254e351 
… test (python#110832)

Co-authored-by: Filipe Laíns <lains@riseup.net>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@lysnikolaou @FFY00
@serhiy-storchaka @Glyphack
pythongh-107450: Check for overflow in the tokenizer and fix overflow…
b5fe2fd 
… test (python#110832)

Co-authored-by: Filipe Laíns <lains@riseup.net>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

@ambv ambv Awaiting requested review from ambv

Assignees

@lysnikolaou lysnikolaou

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysnikolaou @bedevere-bot @miss-islington @serhiy-storchaka @pablogsal