gh-107652: Fix CIFuzz build

[sobolevn]

When CI job was skipped the job was failing: https://github.com/python/cpython/actions/runs/6459321247/job/17536559744?pr=110573

Error: The template is not valid. .github/workflows/build.yml (Line: 620, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.

This happened because run_cifuzz was not set. Now we use the same logic as for other tools by setting it to false

Refs #107653
Refs #107652

[hugovk]

There's an error with this, please could you check?

[hugovk]

cc @illia-v

[illia-v]

I'm sorry for the error. Thank you for the fix!

[hugovk]

Do I get this logic right?

First part:

• [ "$GITHUB_BASE_REF" = "main" ] - this is a PR

Second part:

• git diff --name-only origin/$GITHUB_BASE_REF.. - lists files changed compared with main

• grep -qvE $FUZZ_RELEVANT_FILES - checks the changed files are NOT of the relevant type

• -eq 1 - error code 1, so true only when the files ARE found

---

Instead of checking no match is false: (...; echo $?)" -eq 1

Can we check for a match, something along the lines of this?

Suggested change

	if [ "$GITHUB_BASE_REF" = "main" ] && [ "$(git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qvE $FUZZ_RELEVANT_FILES; echo $?)" -eq 1 ]; then
	if [ "$GITHUB_BASE_REF" = "main" ] && [ "$(git diff --name-only origin/$GITHUB_BASE_REF.. | grep -qE $FUZZ_RELEVANT_FILES)" ]; then

[sobolevn]

When using grep -q in $(), we have to rely on exit code, because no output is produced.

So:

(.venv) ~/Desktop/cpython  fix-ci-fuzz-build ✔                                            
» echo 'abc' | grep -qE 'b'; echo $?
0
                                                                                           
(.venv) ~/Desktop/cpython  fix-ci-fuzz-build ✔                                            
» echo 'abc' | grep -qE 'y'; echo $?
1

[hugovk]

Thanks!

[sobolevn]

Btw, I use https://explainshell.com/explain?cmd=grep+-qE all the time, can recommend for bash reviews :)

Thanks, everyone!

[sobolevn]

I can verify that my C changes now trigger CIFuzz: #110573

[hugovk]

#109854 was created before merging CIFuzz, it changed .pre-commit-config.yaml and Tools/patchcheck/patchcheck.py.

I updated it from main, and it did the CIFuzz checks, somewhat surprisingly.

Do you know why?

[illia-v]

@hugovk I guess it happened because the merge commit contained changes to the relevant files