Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-110178: Use fewer weakrefs in test_typing.py #110194

Merged
merged 1 commit into from
Oct 2, 2023
Merged

gh-110178: Use fewer weakrefs in test_typing.py #110194

merged 1 commit into from
Oct 2, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Oct 1, 2023 •
edited by bedevere-app bot
Loading

Confirmed that without the C changes from #108517, this test still segfaults with only 10 weakrefs.

@JelleZijlstra
pythongh-110178: Use fewer weakrefs
7b599ab 
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting review labels Oct 1, 2023
@bedevere-app bedevere-app bot mentioned this pull request Oct 1, 2023
Closed
AlexWaygood
AlexWaygood approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have not verified that it still segfaults with only 10 weakrefs without the fix, but I trust you to have checked properly :D

@JelleZijlstra JelleZijlstra merged commit 732ad44 into python:main Oct 2, 2023
@miss-islington
Copy link
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstra JelleZijlstra deleted the lessweak branch October 2, 2023 15:03
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 2, 2023
@JelleZijlstra @miss-islington
pythongh-110178: Use fewer weakrefs in test_typing.py (pythonGH-110194)
6c82b0b 
Confirmed that without the C changes from pythonGH-108517, this test still segfaults with only 10 weakrefs.
(cherry picked from commit 732ad44)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 2, 2023

GH-110224 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 2, 2023
AlexWaygood pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @JelleZijlstra
[3.12] gh-110178: Use fewer weakrefs in test_typing.py (GH-110194) (#…
46e6957 
…110224)

gh-110178: Use fewer weakrefs in test_typing.py (GH-110194)

Confirmed that without the C changes from GH-108517, this test still segfaults with only 10 weakrefs.
(cherry picked from commit 732ad44)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@JelleZijlstra @Glyphack
pythongh-110178: Use fewer weakrefs in test_typing.py (python#110194)
7bc7e2b 
Confirmed that without the C changes from python#108517, this test still segfaults with only 10 weakrefs.
@JelleZijlstra JelleZijlstra restored the lessweak branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JelleZijlstra @miss-islington @AlexWaygood