Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] bpo-33127: Compatibility patch for LibreSSL 2.7.0 (GH-6210) #10994

Merged
merged 3 commits into from
Mar 1, 2019

Conversation

aexvir
Copy link

@aexvir aexvir commented Dec 6, 2018

LibreSSL 2.7 introduced OpenSSL 1.1.0 API. The ssl module now detects
LibreSSL 2.7 and only provides API shims for OpenSSL < 1.1.0 and
LibreSSL < 2.7.

Documentation updates and fixes for failing tests will be provided in
another patch set.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue33127

LibreSSL 2.7 introduced OpenSSL 1.1.0 API. The ssl module now detects
LibreSSL 2.7 and only provides API shims for OpenSSL < 1.1.0 and
LibreSSL < 2.7.

Documentation updates and fixes for failing tests will be provided in
another patch set.

Signed-off-by: Christian Heimes <christian@python.org>
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@aexvir aexvir changed the title bpo-33127: Compatibility patch for LibreSSL 2.7.0 (GH-6210) [3.5] bpo-33127: Compatibility patch for LibreSSL 2.7.0 (GH-6210) Dec 6, 2018
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Dec 6, 2018
@larryhastings
Copy link
Contributor

@tiran could you please review this and mark it as Approved on GitHub? That will make the workflow happy, and I'm sure all of us here want the computers to be happy.

@larryhastings larryhastings requested a review from tiran February 26, 2019 02:07
@tiran
Copy link
Member

tiran commented Feb 28, 2019

@larryhastings The patch to _ssl.c looks goot to me. I verified that it fixes compilation with LibreSSL 2.7.5 and 2.8.3. Most tests are passing except for some known issues with LibreSSL.

I'd prefer to drop multissltest from the patch. The version from the PR is outdated.

Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Thanks, Larry 👍

@larryhastings larryhastings merged commit 56f8783 into python:3.5 Mar 1, 2019
@bedevere-bot
Copy link

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

Thanks, everybody! This is probably the last patch that'll go into 3.5.7.

@aexvir aexvir deleted the backport-4ca0739-3.5 branch March 10, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants