gh-109546: Add more tests for formatting floats and fractions #109548

serhiy-storchaka · 2023-09-18T16:01:11Z

Issue: Add more tests for formatting floats and fractions #109546

vstinner

I would prefer to not load test_float in test_fractions just to get a filename.

vstinner · 2023-09-18T16:32:18Z

Lib/test/test_fractions.py

@@ -1220,6 +1220,30 @@ def test_invalid_formats(self):
                with self.assertRaises(ValueError):
                    format(fraction, spec)

+    @requires_IEEE_754
+    def test_float_format_testfile(self):
+        from test.test_float import format_testfile


I would prefer to just copy/paste the code to get the path here:

format_testfile = os.path.join(test_dir, 'formatfloat_testcases.txt')

I prefer to not make tests inter-dependents. Sometimes, just importing a test has side effects.

vstinner · 2023-09-18T16:33:53Z

Lib/test/test_fractions.py

+                    continue
+                line = line.strip()
+                if not line:
+                    continue


I suppose that such logic is used in other files using formatfloat_testcases.txt. Is there a good place to share common code?

If we add mathdata/, can we add a helper function there which would iterate on the file and strip comments?

I was going to add it in test_float, but it is simple enough, so I just copied it.

vstinner · 2023-09-18T16:36:03Z

Lib/test/test_fractions.py

+                if fmt == '%r':
+                    continue
+                with self.subTest(fmt=fmt, arg=arg):
+                    f = F(float(arg))


Maybe add a variable for fmt[1:].

mdickinson · 2023-09-18T18:28:15Z

+1 for the idea, and code changes LGTM.

miss-islington · 2023-09-19T05:09:15Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

…ythonGH-109548) (cherry picked from commit beb5ec5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app · 2023-09-19T05:09:30Z

GH-109557 is a backport of this pull request to the 3.12 branch.

bedevere-bot · 2023-09-19T05:19:22Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 3.x has failed when building commit beb5ec5.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/185/builds/5034) and take a look at the build logs.
Check if the failure is related to this commit (beb5ec5) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/185/builds/5034

Failed tests:

test.test_multiprocessing_fork.test_misc

Failed subtests:

test_nested_startmethod - test.test_multiprocessing_fork.test_misc.TestStartMethod.test_nested_startmethod

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-x86_64/build/Lib/test/_test_multiprocessing.py", line 5475, in test_nested_startmethod
    self.assertEqual(results, [2, 1])
AssertionError: Lists differ: [1, 2] != [2, 1]

bedevere-bot · 2023-09-19T05:42:44Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x has failed when building commit beb5ec5.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/469/builds/6024) and take a look at the build logs.
Check if the failure is related to this commit (beb5ec5) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/469/builds/6024

Failed tests:

test.test_asyncio.test_subprocess

Failed subtests:

test_subprocess_consistent_callbacks - test.test_asyncio.test_subprocess.SubprocessThreadedWatcherTests.test_subprocess_consistent_callbacks

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/test_asyncio/test_subprocess.py", line 788, in test_subprocess_consistent_callbacks
    self.loop.run_until_complete(main())
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/asyncio/base_events.py", line 664, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL8-fips-x86_64.no-builtin-hashes-except-blake2/build/Lib/test/test_asyncio/test_subprocess.py", line 780, in main
    self.assertEqual(events, [
AssertionError: Lists differ: [('pi[29 chars]t'), 'pipe_connection_lost', ('pipe_data_recei[57 chars]ted'] != [('pi[29 chars]t'), ('pipe_data_received', 2, b'stderr'), 'pi[57 chars]ted']

bedevere-bot · 2023-09-19T06:17:48Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL7 LTO + PGO 3.x has failed when building commit beb5ec5.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/43/builds/4246) and take a look at the build logs.
Check if the failure is related to this commit (beb5ec5) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/43/builds/4246

Failed tests:

test.test_multiprocessing_fork.test_processes

Summary of the results of the build (if available):

==

Click to see traceback logs

remote: Enumerating objects: 6, done.        
remote: Counting objects:  16% (1/6)        
remote: Counting objects:  33% (2/6)        
remote: Counting objects:  50% (3/6)        
remote: Counting objects:  66% (4/6)        
remote: Counting objects:  83% (5/6)        
remote: Counting objects: 100% (6/6)        
remote: Counting objects: 100% (6/6), done.        
remote: Compressing objects:  16% (1/6)        
remote: Compressing objects:  33% (2/6)        
remote: Compressing objects:  50% (3/6)        
remote: Compressing objects:  66% (4/6)        
remote: Compressing objects:  83% (5/6)        
remote: Compressing objects: 100% (6/6)        
remote: Compressing objects: 100% (6/6), done.        
remote: Total 6 (delta 0), reused 0 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch            main       -> FETCH_HEAD
Note: checking out 'beb5ec5817b645562ebbdd59f25683a93061c32c'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at beb5ec5... gh-109546: Add more tests for formatting floats and fractions (GH-109548)
Switched to and reset branch 'main'

find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
find: ‘build’: No such file or directory
make[2]: [Makefile:2807: clean-retain-profile] Error 1 (ignored)
./Modules/_testcapi/unicode.c: In function ‘test_string_from_format’:
./Modules/_testcapi/unicode.c:1538:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored))
 ^~~~~~~~~~~~~~~~~~~~~~~
./Modules/_testcapi/unicode.c: In function ‘test_string_from_format’:
./Modules/_testcapi/unicode.c:1538:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
 test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored))
 ^
./Modules/_decimal/libmpdec/context.c:57: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time

./Modules/_decimal/libmpdec/context.c:57: warning: mpd_setminalloc: ignoring request to set MPD_MINALLOC a second time


make: *** [Makefile:2027: buildbottest] Error 5

miss-islington · 2023-09-21T19:08:25Z

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington · 2023-09-21T19:08:27Z

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker beb5ec5817b645562ebbdd59f25683a93061c32c 3.11

vstinner · 2023-09-21T19:12:28Z

Oh. I tried to backport this change to 3.11 to prepare backporting PR #109512 to 3.11 and 3.12, but the fractions module doesn't support all formatting syntax in 3.11:

ERROR: test_float_format_testfile (test.test_fractions.FractionTest.test_float_format_testfile) (fmt='%.1g', arg='10')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/vstinner/python/3.11/Lib/test/test_fractions.py", line 856, in test_float_format_testfile
    self.assertEqual(format(f, fmt2), rhs)
                     ^^^^^^^^^^^^^^^
TypeError: unsupported format string passed to Fraction.__format__

So this change cannot be backported.

(cherry picked from commit beb5ec5)

bedevere-app · 2023-09-21T19:13:16Z

GH-109685 is a backport of this pull request to the 3.11 branch.

vstinner · 2023-09-21T19:13:31Z

I partially backported the change to 3.11: only test_float changes.

…109685) gh-109546: Add more tests for formatting floats (GH-109548) (cherry picked from commit beb5ec5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

…ythonGH-109548)

…H-109548) (#109557) gh-109546: Add more tests for formatting floats and fractions (GH-109548) (cherry picked from commit beb5ec5) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

pythongh-109546: Add more tests for formatting floats and fractions

948747a

serhiy-storchaka added skip news needs backport to 3.12 bug and security fixes labels Sep 18, 2023

serhiy-storchaka requested a review from mdickinson September 18, 2023 16:01

bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Sep 18, 2023

bedevere-app bot mentioned this pull request Sep 18, 2023

Add more tests for formatting floats and fractions #109546

Closed

serhiy-storchaka mentioned this pull request Sep 18, 2023

gh-108303: Move all math files to Lib/test/mathdata/ #109512

Merged

vstinner reviewed Sep 18, 2023

View reviewed changes

Address review comments.

22245e4

serhiy-storchaka force-pushed the test_float_format_testfile branch from 18c9aab to 22245e4 Compare September 18, 2023 17:45

mdickinson approved these changes Sep 18, 2023

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Sep 18, 2023

serhiy-storchaka merged commit beb5ec5 into python:main Sep 19, 2023

bedevere-app bot removed the awaiting core review label Sep 19, 2023

serhiy-storchaka deleted the test_float_format_testfile branch September 19, 2023 05:09

bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 19, 2023

vstinner added the needs backport to 3.11 only security fixes label Sep 21, 2023

miss-islington assigned serhiy-storchaka Sep 21, 2023

vstinner removed the needs backport to 3.11 only security fixes label Sep 21, 2023

vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 21, 2023

pythongh-109546: Add more tests for formatting floats (pythonGH-109548)

6f0c599

(cherry picked from commit beb5ec5)

vstinner mentioned this pull request Sep 21, 2023

Move test files into test subdirectories #108303

Closed

csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023

pythongh-109546: Add more tests for formatting floats and fractions (p…

be83a3a

…ythonGH-109548)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-109546: Add more tests for formatting floats and fractions #109548

gh-109546: Add more tests for formatting floats and fractions #109548

serhiy-storchaka commented Sep 18, 2023 •

edited by bedevere-app bot

Loading

vstinner left a comment

vstinner Sep 18, 2023

vstinner Sep 18, 2023

serhiy-storchaka Sep 18, 2023

vstinner Sep 18, 2023

serhiy-storchaka Sep 18, 2023

mdickinson commented Sep 18, 2023

miss-islington commented Sep 19, 2023

bedevere-app bot commented Sep 19, 2023

bedevere-bot commented Sep 19, 2023

bedevere-bot commented Sep 19, 2023

bedevere-bot commented Sep 19, 2023

miss-islington commented Sep 21, 2023

miss-islington commented Sep 21, 2023

vstinner commented Sep 21, 2023

bedevere-app bot commented Sep 21, 2023

vstinner commented Sep 21, 2023

gh-109546: Add more tests for formatting floats and fractions #109548

gh-109546: Add more tests for formatting floats and fractions #109548

Conversation

serhiy-storchaka commented Sep 18, 2023 • edited by bedevere-app bot Loading

vstinner left a comment

Choose a reason for hiding this comment

vstinner Sep 18, 2023

Choose a reason for hiding this comment

vstinner Sep 18, 2023

Choose a reason for hiding this comment

serhiy-storchaka Sep 18, 2023

Choose a reason for hiding this comment

vstinner Sep 18, 2023

Choose a reason for hiding this comment

serhiy-storchaka Sep 18, 2023

Choose a reason for hiding this comment

mdickinson commented Sep 18, 2023

miss-islington commented Sep 19, 2023

bedevere-app bot commented Sep 19, 2023

bedevere-bot commented Sep 19, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Sep 19, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented Sep 19, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

miss-islington commented Sep 21, 2023

miss-islington commented Sep 21, 2023

vstinner commented Sep 21, 2023

bedevere-app bot commented Sep 21, 2023

vstinner commented Sep 21, 2023

serhiy-storchaka commented Sep 18, 2023 •

edited by bedevere-app bot

Loading