Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling in _PySys_UpdateConfig() #109524

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix error handling in _PySys_UpdateConfig() #109524

merged 1 commit into from
Sep 18, 2023

Conversation

serhiy-storchaka
Copy link
Member

  1. _PySys_GetObject() can return NULL without setting an error.
  2. Error in PyDict_SetItemString() was not handled.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 17, 2023
ericsnowcurrently
ericsnowcurrently approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently
Copy link
Member

Thanks for catching this and for the fix!

@serhiy-storchaka serhiy-storchaka merged commit c829975 into python:main Sep 18, 2023
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the _PySys_UpdateConfig-errors branch September 18, 2023 17:10
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
@serhiy-storchaka @miss-islington
Fix error handling in _PySys_UpdateConfig() (pythonGH-109524)
5adce41 
(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2023

GH-109550 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
@serhiy-storchaka @miss-islington
Fix error handling in _PySys_UpdateConfig() (pythonGH-109524)
9e8e018 
(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 18, 2023

GH-109551 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Sep 18, 2023
serhiy-storchaka added a commit that referenced this pull request Sep 18, 2023
@miss-islington @serhiy-storchaka
[3.11] Fix error handling in _PySys_UpdateConfig() (GH-109524) (GH-10…
17a335d 
…9551)

(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@serhiy-storchaka @csm10495
Fix error handling in _PySys_UpdateConfig() (pythonGH-109524)
6d6ceb9
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @serhiy-storchaka
[3.12] Fix error handling in _PySys_UpdateConfig() (GH-109524) (#109550)
df2cdcf 
Fix error handling in _PySys_UpdateConfig() (GH-109524)
(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @ericsnowcurrently @miss-islington