Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-109214: Rename SAVE_IP to _SET_IP, and similar #109285

Merged
merged 7 commits into from
Sep 11, 2023

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Sep 11, 2023

All uops now have a name starting with _, which makes it easier to tell them apart from Tier 1 bytecode instruction names.

This is the first step for issue gh-109214.

I'll just merge this once tests pass.

CC: @markshannon @Fidget-Spinner @brandtbucher @iritkatriel

@gvanrossum gvanrossum merged commit fbaf77e into python:main Sep 11, 2023
@gvanrossum gvanrossum deleted the rename-uops branch September 11, 2023 22:40
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
* Rename SAVE_IP to _SET_IP
* Rename EXIT_TRACE to _EXIT_TRACE
* Rename SAVE_CURRENT_IP to _SAVE_CURRENT_IP
* Rename INSERT to _INSERT (This is for Ken Jin's abstract interpreter)
* Rename IS_NONE to _IS_NONE
* Rename JUMP_TO_TOP to _JUMP_TO_TOP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant